[U-Boot-Users] 85xx SPD LAW setup issue?

[Kumar Gala]

On Nov 8, 2006, at 4:45 AM, Sam Song wrote:

> Hi,
>
> I found that there is a possible LAW conflict
> between SPD and 85xx default settings.
>
> LAWBAR0 is used for DDR whereas LAWBAR1 for
> PCI1. But SPD initializes DDR LAW as LAWBAR1.
>
> I think it could be a setup mess, right?

Agreed, however I do remember something about wanting to keep LAWBAR0  
free always to allow an external agent to do things.  Maybe Jon  
remembers more about that than I do.

- k


> diff --git a/cpu/mpc85xx/spd_sdram.c
> b/cpu/mpc85xx/spd_sdram.c
> index 6da5367..c4d3956 100644
> --- a/cpu/mpc85xx/spd_sdram.c
> +++ b/cpu/mpc85xx/spd_sdram.c
> @@ -1043,12 +1043,12 @@ setup_laws_and_tlbs(unsigned
> int memsize
>         /*
>          * Set up LAWBAR for all of DDR.
>          */
> -       ecm->lawbar1 = ((CFG_DDR_SDRAM_BASE >> 12) &
> 0xfffff);
> -       ecm->lawar1 = (LAWAR_EN
> +       ecm->lawbar0 = ((CFG_DDR_SDRAM_BASE >> 12) &
> 0xfffff);
> +       ecm->lawar0 = (LAWAR_EN
>                        | LAWAR_TRGT_IF_DDR
>                        | (LAWAR_SIZE & law_size));
> -       debug("DDR: LAWBAR1=0x%08x\n", ecm->lawbar1);
> -       debug("DDR: LARAR1=0x%08x\n", ecm->lawar1);
> +       debug("DDR: LAWBAR0=0x%08x\n", ecm->lawbar0);
> +       debug("DDR: LARAR0=0x%08x\n", ecm->lawar0);
>
>         /*
>          * Confirm that the requested amount of memory
> was mapped.
>
> Best regards,
>
> Sam
>
>
> 		
> ___________________________________________________________
> 抢注雅虎免费邮箱-3.5G容量，20M附件！
> http://cn.mail.yahoo.com
>
> ---------------------------------------------------------------------- 
> ---
> Using Tomcat but need to do more? Need to support web services,  
> security?
> Get stuff done quickly with pre-integrated technology to make your  
> job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache  
> Geronimo
> http://sel.as-us.falkag.net/sel? 
> cmd=lnk&kid=120709&bid=263057&dat=121642______________________________ 
> _________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users