[U-Boot-Users] ixdp465 support

[Wolfgang Denk]

In message <455994C6.7050803 at gandalf.sssup.it> you wrote:
> 
>    since we didn't have enough spare time to prepare a clean patch for 
> the IXDP465 support, we decided to put the current patch on our website 
> (http://www.evidence.eu.com/content/view/104/119/).
> 
> The patch is released under GPL license.

It is *extremely* bad style to post the same information with slightly
different text to different mailing lists.

Here is a copy of my reply to Claudio Scordino's posting on the
linux-arm list:

------- Forwarded Message

Date:    Tue, 14 Nov 2006 21:49:51 +0100
From:    Wolfgang Denk <wd at denx.de>
To:      Claudio Scordino <cloud.of.andor at gmail.com>
cc:      Arm Linux <linux-arm at lists.arm.linux.org.uk>
Subject: Re: U-boot on Intel IXDP465 

In message <4559CB56.1060504 at gmail.com> you wrote:
>=20
> Evidence Srl has just finished the porting of the U-boot bootloader to
> the Intel IXDP465 development platform (featuring a Intel IXP465 Xscale
> microprocessor). The patch adds the support for the microprocessor, the

So why don't you post it to  the  appropirate  mailing  list,  i.  e.
u-boot-users? It's off topic here.

Note 1: the resulting binary cannot be distributed, as you have a
        license conflict with the Intel NPE code. You MUST NOT link
        U-Boot (under GPL) with this code.

Note 2: your patch contains garbage; for example, it creates files
        like Makefile.orig, cpu/ixp/cpu.c.orig,
        cpu/ixp/interrupts.c.orig, cpu/ixp/serial.c.orig,
        cpu/ixp/timer.c.orig, drivers/pci_indirect.c.orig,
        cpu/ixp/config.mk.orig, ... which must not be included.

        Also, pippo.txt is poroibably random garbage and  should  not
        be included.

Note 3: For CFI conformant flash chips you should use the CFI driver
	instead of a custom one.

Note 4: Your patch violates the coding style (C++ comments,
	trailing white space, indentation not by TABs, etc.). Please
	cleanup.

Note 5: You patch adds debug code to common files (like
	common/cmd_bootm.c). You must never do this!

Note 6: Please doin;t add changelog style comments to files (like in
        cpu/ixp/start.S); we use git to track the history.

Note 7: Please don't modify white space in files which you don't
        touch at all (like drivers/cfi_flash.c).

Note 8: Be careful with hardware accesses; code like function
        get_reg() in drivers/ethixdp465.c is missing "volatile"
        attributes. Check all your code for this!

So please clean up your code, fix the license issue, and (re-) submit
your code on u-boot-users.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every little picofarad has a nanohenry all its own.      - Don Vonada

------- End of Forwarded Message



And please don't try to put the burdon to clean up your
mess^H^H^H^Hcode on others!

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nearly everyone is in favor of going  to  heaven  but  too  many  are
hoping  they'll  live  long  enough  to see an easing of the entrance
requirements. Never appeal to a man's "better nature." he  might  not
have one.