[U-Boot-Users] Please pull u-boot-83xx.git (I2C rework)

Ben Warren bwarren at qstreams.com
Mon Nov 27 03:45:19 CET 2006


Hi Stefan,

--- Stefan Roese <sr at denx.de> wrote:

> Hi Ben,
> 
> On Saturday 04 November 2006 03:11, Kim Phillips
> wrote:
> > Please pull from 'master' branch of:
> >
> >  
>
http://opensource.freescale.com/pub/scm/u-boot-83xx.git
> >
> > to receive the following updates (essentially
> MPC8349mITX and MPC8360EMDS
> > support):
> >
> > Ben Warren:
> >       Add support for multiple I2C buses
> >       Multi-bus I2C implementation of MPC834x
> >       Additional MPC8349 support for multibus i2c
> 
> I'm commenting on the I2C code you submitted, which
> is now included in the
> git tree of Kim Phillips. Sorry for the late review,
> but I have some more
> or less cosmetic comments:

Sorry about the formatting.  I've been influenced by
many coding 'standards' over the years and haven't
quite adapted to the kernel way yet...  Old habits die
hard. 

To keep things moving, I'll fix this up and forward to
Kim on Monday morning.  I'm sure he has better things
to do than fix my sloppy styling.

Speaking of keeping things moving - I submitted a SPI
driver for the MPC834x several months back.  I'm sure
it has the same formatting problems.  Will it be
faster for me to resubmit?

regards,
Ben




More information about the U-Boot mailing list