[U-Boot-Users] Please pull u-boot-83xx.git (I2C rework)

Joakim Tjernlund joakim.tjernlund at transmode.se
Tue Nov 28 14:54:40 CET 2006


> -----Original Message-----
> From: u-boot-users-bounces at lists.sourceforge.net 
> [mailto:u-boot-users-bounces at lists.sourceforge.net] On Behalf 
> Of Stefan Roese
> Sent: 27 November 2006 07:22
> To: u-boot-users at lists.sourceforge.net
> Cc: Kim Phillips; Ben Warren; Wolfgang Denk
> Subject: Re: [U-Boot-Users] Please pull u-boot-83xx.git (I2C rework)
> 
> Hi Ben,
> 
> On Monday 27 November 2006 03:45, Ben Warren wrote:
> > Sorry about the formatting.  I've been influenced by
> > many coding 'standards' over the years and haven't
> > quite adapted to the kernel way yet...  Old habits die
> > hard.
> 
> ;-)
> 
> > To keep things moving, I'll fix this up and forward to
> > Kim on Monday morning.  I'm sure he has better things
> > to do than fix my sloppy styling.
> 
> Good idea. If I remember correctly, Kim is not available 
> until mid of this 
> week.
> 
> > Speaking of keeping things moving - I submitted a SPI
> > driver for the MPC834x several months back.  I'm sure
> > it has the same formatting problems.  Will it be
> > faster for me to resubmit?
> 
> Yes. You would save us at least one round of code review & 
> resubmit. It's also 
> easier to have a patch based on the current git tree.
> 
> Best regards,
> Stefan

I think that the I2C_READ and I2C_WRITE #defines in fsl_i2c.h conflicts
with
soft I2C.

 Jocke




More information about the U-Boot mailing list