[U-Boot-Users] [PATCH 2/5] Support LATTICE FPGA parts using JTAG programming.

[Wolfgang Denk]

In message <035A383E-D0CC-4A02-A49F-B98EA7D676EA at embeddedalley.com> you wrote:
> 
> >>  common/ec.c                |  473 ++++++
> > ^^^^^^^^^^^^^^
> > Huh? What's "ec"? Please use a more descriptive name.
> 
> EC is the family name for the parts - follows the convention by the
> virtex & spartan families.

lattice_ec ?

> ...
> As a general comment, this is the same file that RedBoot uses - it's  
> lattice code,
> so I didn't do much with it. Yes the formatting is pretty horrible.
> And the comments are pretty misleading.

Do you see a chance of cleaning this up / re-implementing the needed
parts in a clean way in some foreseeable future?

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
On my planet, to rest is to rest -- to cease using energy. To me,  it
is  quite  illogical to run up and down on green grass, using energy,
instead of saving it.
	-- Spock, "Shore Leave", stardate 3025.2