[U-Boot-Users] [PATCH] New NAND subsystem: mtd like commands support jffs2 and bad blocks

[Guido Classen]

Hi Stefan,

thanks for your comments.

>> ... a lot of patch ...
>> +
>> +	for (;
>> +	     erase.addr < opts->offset + erase_length;
>> +	     erase.addr += meminfo->erasesize) {
>> +
>> +		WATCHDOG_RESET ();
>> +
>> +		if ( !opts->scrub && bbtest ) {
>
>No spaces after opening brace and before closing brace.
>

Now I finally know what you meant. AFAIK the round ones are called
parenthesis, not brace! Braces are the curly and square onse.


>> +
>> +
>> +#endif /* (CONFIG_COMMANDS & CFG_CMD_NAND) && !defined(CFG_NAND_LEGACY) */
>> +
>> +/*
>> + *Local Variables:
>> + * mode: c
>> + * End:
>> + */
>
>Please remove this c-style paragraph.
>
Okay

>Now it compiles clean for my testplatform. Thanks.
>
>As it seems you have set the "quiet" option for all commands. Because of
>this we don't see the skipping of bad blocks message for example. So please
>disable the quiet option.
>

You're right. I set the "quiet" option for all commands. I have done some
testing again and get an impression that the output of progress messages on
the serial console takes too much time. It seems that they slow down the
operations especially on small page devices (four times more messages). Hence
I think the best solution would be to make them switchable on command line, so
they can be switched on for testing and off for normal operation.

Maybe a "quiet" option at command line for the related commands (like "clean"
option) will be the right way to do it. What do you think about this?

I will rework the patch with your suggestions as soon as provisions to switch
on/off the "quiet" option and resubmit it the next days.

Regards

  Guido