[U-Boot-Users] [PATCH] Spansion Flash configuration words

Wolfgang Denk wd at denx.de
Mon Oct 9 01:30:46 CEST 2006


In message <20060704114008.GX23183 at scorpius.homelinux.org> you wrote:
> 
> * Add the configuration words for the Spansion flash S29GL128N,
>   S29GL256N and S29GL512N
>   Patch by Marc Leeman, 4 Jul 2006

I reject this patch. First, it adds unreferences defintions - these
are used nowhere in the code.

Second, as Anders Larsen already pointed out, you should use the  CFI
flash driver on such devices which does not need these defines.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Einstein argued that there must be simplified explanations of nature,
because God is not capricious or arbitrary. No  such  faith  comforts
the software engineer.                             - Fred Brooks, Jr.




More information about the U-Boot mailing list