[U-Boot-Users] [PATCH] [RFC] Add Device tree support to lite5200b eval board

[Wolfgang Denk]

In message <11617655783887-git-send-email-grant.likely at secretlab.ca> you wrote:
> Please comment on this patch.  This is not the final patch as applying this
> one prevents booting an arch/ppc kernel (due to adding CONFIG_OF_FLAT_TREE
> to include/configs/IceCube.h).
> 
> I have not yet successfully booted an arch/powerpc kernel using this change,
> but I want feedback to ensure I've twiddled the correct bits.  :)

I can just comment on formal things.

> +	p = ft_get_prop(blob, "/cpus/" OF_CPU "/bus-frequency", &len);
> +	if (p != NULL)
> +		*p = cpu_to_be32(clock);
> +
> +	p = ft_get_prop(blob, "/" OF_SOC "/serial at 2000/clock-frequency", &len);
> +	if (p != NULL)
> +		*p = cpu_to_be32(clock);
> +
> +	p = ft_get_prop(blob, "/" OF_SOC "/serial at 2200/clock-frequency", &len);
> +	if (p != NULL)
> +		*p = cpu_to_be32(clock);
> +
> +	p = ft_get_prop(blob, "/" OF_SOC "/serial at 2400/clock-frequency", &len);
> +	if (p != NULL)
> +		*p = cpu_to_be32(clock);
> +
> +	p = ft_get_prop(blob, "/" OF_SOC "/serial at 2600/clock-frequency", &len);
> +	if (p != NULL)
> +		*p = cpu_to_be32(clock);
> +
> +	p = ft_get_prop(blob, "/" OF_SOC "/serial at 2800/clock-frequency", &len);
> +	if (p != NULL)
> +		*p = cpu_to_be32(clock);
> +
> +	p = ft_get_prop(blob, "/" OF_SOC "/serial at 2c00/clock-frequency", &len);
> +	if (p != NULL)
> +		*p = cpu_to_be32(clock);

Please write this as a loop.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It may be that your whole purpose in life is simply  to  serve  as  a
warning to others.