[U-Boot-Users] [PATCH] Add support for variable flash memory sizes on 83xx systems

[Wolfgang Denk]

In message <1157749650960-git-send-email-timur at freescale.com> you wrote:
> 
> * On 83xx systems, use the CFG_FLASH_SIZE macro to program the LBC local access
>   window registers, instead of using a hard-coded value of 8MB. 

THis part of the patch is OK, but please...

> +#ifdef CONFIG_MPC8349ITX
> +/* MPC8349ITX : CS1 */
> +	/* Initialize the BR1 with the vsc7385 starting address. */
> +	lis r5, 0xf8000801 at h
> +	ori r5, r5, 0xf8000801 at l
> +	stw r5, BR1(r3) /* r5 <= (CFG_FLASH_BASE & 0xFFFF8000) | (BR1 & 0x00007FFF) */
> +
> +	lis r5, 0xfffe09ff at h
> +	ori r5, r5, 0xfffe09ff at l
> +	stw r5, OR1(r3)
> +#endif

... don't mix in board-specific  patches  here,  especially  not  for
boards that are not supported in U-Boot yet.

Please clean up and resubmit.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Misquotation is, in fact, the pride and privilege of the  learned.  A
widely-read  man  never  quotes  accurately,  for  the rather obvious
reason that he has read too widely.
                - Hesketh Pearson _Common Misquotations_ introduction