[U-Boot-Users] PATCH add SMN42 board from Siemens

[Peter Pearse]

> -----Original Message-----
> From: u-boot-users-bounces at lists.sourceforge.net 
> [mailto:u-boot-users-bounces at lists.sourceforge.net] On Behalf 
> Of Gary Jennejohn
> Sent: 03 April 2007 15:58
> To: u-boot-users at lists.sourceforge.net
> Subject: [U-Boot-Users] PATCH add SMN42 board from Siemens
> 
> Hi,
> 
> The patch is rather large and can be downloaded at
> 	ftp://ftp.denx.de/pub/patches/SMN42_NEW
> 
> The eth.c files for lpc2292sodimm and SMN42 are identical, 
> but the driver is very board-specific and cannot be put into 
> e.g. drivers.

Gary

	I stand ready to be corrected, but I thought the way round that
was

a) move the eth.c to drivers/<unique name>.c
b) add <unique_name>.o to the object list in drivers/Makefile
c) encapsulate the code with #ifdef CONFIG_<UNIQUE_DEF>
d) add #define CONFIG_<UNIQUE_DEF> to the include/configs/<board>.h for
the lpc2292sodimm and SMN42 boards
e) check I haven't missed anything from this list.....

see e.g drivers/smc91111.c used by DK1C20, DK1S10, EP1C20 etc   

This might still be possible if the lpc2292sodimm and SMN42 eth.c differ
slightly,
using a board specific define.....

Regards

Peter

-- 
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.