[U-Boot-Users] [PATCH] FreeScale MC68360 support

[Wolfgang Denk]

In message <8496f91a0704111258g7bd22c55m43d0e17799185b69 at mail.gmail.com> you wrote:
>
> > many different boards using this processor, so you will have to chose
> > a more descriptive board name.
> 
> Yes, you are right. MC68360 is the name of the CPU. But the board I'm
> working
> at right now is my own design. That's why I can't do it.

Can't do it? You cannot give your own board a name? Why not?!?

> > least release 1.2.0).
> 
> Ooops, I was not aware of it. As far as I know, there was no official
> information about it.

Yes, there was.

> Then, there are some coding style issues with your patch (indentation
> > not by TAB, indentation not by multiple of 8 columns, trailing  white
> > space,  C++  comments,  too long lines, etc.) as well as other formal
> > issues (missing Copyright entries, missing license  headers,  missing
> > Signed-off-by: line).
> 
> Ok. Could you tell me where I can get exact information about it?

Start at http://www.denx.de/wiki/UBoot, and make sure to read at
lkeast the README.

> #define CFG_SDRAM_SIZE                 0x00800000
> >
> > Please don't do that. U-Boot style is to allow auto-adjustment to the
> > actual RAM size.
> >
> > #define CFG_MALLOC_LEN                 (5*1024*1024)
> >
> > You have 8 MB of RAM and reserve 5 MB for malloc()? This seems broken
> > to me.
> 
> Why not? I really have it working :)

You cannot load a Linux kernel and a ramdisk on such a system, while
there are still ~5 MB of malloc space unused.

> You comment out relevant parts of lib_m68k/board.c - you must not do
> > that!
> 
> Could you tell me the reason why I should not do it?

Because lib_m68k/board.c is common code  which  you  share  with  all
other m68k boards. You must not mess with this.

> I will take into consideration your advice and recommendations. And I'll try
> to correct my patch.

Thanks.

> ------=_Part_4889_10802702.1176321492201
> Content-Type: text/html; charset=ISO-8859-1
> Content-Transfer-Encoding: 7bit
> Content-Disposition: inline

But please NEVER post HTML here again!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The idea of male and female are universal constants.
	-- Kirk, "Metamorphosis", stardate 3219.8