[U-Boot-Users] [PATCH] Fix use of "void *" for block dev read/write buffer pointers

Denis Peter d.peter at mpl.ch
Fri Apr 13 08:45:32 CEST 2007

Hello Stefan,

On Friday 13 April 2007 07:56, Stefan Roese wrote:
> Hi Denis,
> On Thursday 12 April 2007 22:27, Grant Likely wrote:
> > On 4/12/07, Greg Lopp <lopp at pobox.com> wrote:
> > > Signed-off-by: Greg Lopp <lopp at pobox.com>
> >
> > Acked-by: Grant Likely <grant.likely at secretlab.ca>
> >
> > Stefan, can you pick this one up please?
> Yes I will. Just checking with an older patch that tried to fix this issue:
> Denis, could you please take a look at this patch and let me know if this 
> patch supersedes your patch:
> "Re: [U-Boot-Users] [PATCH] Fix bugs in cmd_ide.c and cmd_scsi.c"
> from April, 2nd?

My patch from April, 2nd, fixes this issue already. In my patch I decided to just 
cast the pointer back to ulong *, since I don't know if it is a good idea to increment 
a pointer to void *. 
But the same bug is also in cmd_scsi.c which also fixed by my patch. The other bug
which prevented to use the command "diskboot" and "scsiboot" from other devices than
device 0, is also fixed by my patch.
It seems that the function atapi_read slipped my attention, this function is not fixed 
by my patch.

With best regards,


More information about the U-Boot mailing list