[U-Boot-Users] [PATCH] icecube/lite5200b: wakeup from low-power support
Stefan Roese
sr at denx.de
Tue Apr 17 13:29:36 CEST 2007
Hi Domen,
On Monday 16 April 2007 14:04, Stefan Roese wrote:
> On Monday 16 April 2007 06:45, Grant Likely wrote:
> > On 4/3/07, Domen Puncer <domen.puncer at telargo.com> wrote:
> > > U-Boot part of Lite5200b low power mode support.
> > > Puts SDRAM out of self-refresh and transfers control to
> > > address saved at physical 0x0.
> >
> > Looks good; almost there. Only one thing missing... you need to add
> > your "Signed-off-by" line. :-) See Documentation/SubmittingPatches
> > in the Linux source tree. (You can just reply to this message, and
> > whoever merges the patch will add the line to the commit message)
> >
> > Acked-by: Grant Likely <grant.likely at secretlab.ca>
> >
> > Stefan; since there is no 5200 custodian, can you please pick up this
> > patch once Domen sends a Signed-of-by replay?
>
> Done.
Rafal mentioned to me off-list that some documentation about this
suspend/wakeup mechanism would be preferable. Here his notes:
"
- regarding the U-Boot piece I'd only like to see some explanation (as a
comment or short readme file) of the overall concept and scenario as it
is not intuitive at all and rather difficult to understand all the
ramifications and constraints from looking at the code only
"
So Domen, could you please either send a reworked patch with this
documentation (preferable some file in doc/README.xxx) or just send a new
patch with only this documentation?
Thanks.
BTW: Wolfgang reminded me, that putting this stuff into the u-boot-ppc4xx
repository is not a good solution. I'll try to move this over to
u-boot-testing.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
=====================================================================
More information about the U-Boot
mailing list