[U-Boot-Users] [PATCH] Fix memory initialization on MPC8349ITX

Kim Phillips kim.phillips at freescale.com
Wed Apr 25 16:09:02 CEST 2007


On Tue, 24 Apr 2007 11:51:33 -0500
"Benedict, Michael" <MBenedict at twacs.com> wrote:

> Hello,
> 	This is my first patch submission to u-boot, so let me know if
> the format needs to be updated.  Also, I don't know how formal the
> sign-off procedure has to be.  This patch was suggested by Bruce Leonard
> in his 2007/4/20 email to the list, and so I am counting that as
> sign-off.  This patch is against the MPC83xx custodian tree, so I
> apologize if this should instead be sent directly to Kim Phillips.
> 

to:ing or cc:ing me helps me not miss things, but I don't require it. 
It also helps indicate which tree you want it to go through by
inserting, e.g., "mpc83xx: " after "[PATCH]" in the subject line.

> Define CFG_DDR_SDRAM_CLK_CNTL for the MPC8349ITX.  This allows
> ddr->sdram_clk_cntl to be properly initialized, like it was before
> commit f6eda7f80ccc13d658020268c507d7173cf2e8aa to
> cpu/mpc83xx/spd_sdram.c
> 
> Patch initially suggested by Timur Tabi and implemented / tested by
> Bruce Leonard.
> 
> Signed-off-by: Bruce Leonard <Bruce_Leonard at selinc.com>
> 
I added a link for the linux kernel signoff policy here:

http://www.denx.de/wiki/UBoot/DevelopmentProcess

so I'm guessing this patch would be signed off by Bruce, then Michael.

> diff --git a/include/configs/MPC8349ITX.h b/include/configs/MPC8349ITX.h
> index 37bbfb3..e0c0227 100644
> --- a/include/configs/MPC8349ITX.h
> +++ b/include/configs/MPC8349ITX.h
> @@ -149,6 +149,8 @@
>   */
>  #define CFG_DDR_BASE           0x00000000      /* DDR is system
> memory*/

your mailer is wrapping lines.

>  #define CFG_SDRAM_BASE                 CFG_DDR_BASE
> +#define CFG_DDR_SDRAM_CLK_CNTL (DDR_SDRAM_CLK_CNTL_SS_EN | \
> +                               DDR_SDRAM_CLK_CNTL_CLK_ADJUST_05)

tabs, then spaces, please.

Thanks,

Kim




More information about the U-Boot mailing list