[U-Boot-Users] Update for 5329

[Stefan Roese]

Hi TsiChung,

please find some comments below.

On Wednesday 01 August 2007, Liew Tsi Chung-r5aahp wrote:
> Here is the updates:
> 1. Update-CONFIG_MCFUART.patch
> 2. Added-common-define-CONFIG_CF_MII-for-do_mii.patch

> diff --git a/common/cmd_mii.c b/common/cmd_mii.c
> index c3f43d7..181f2e7 100644
> --- a/common/cmd_mii.c
> +++ b/common/cmd_mii.c
> @@ -438,7 +438,7 @@ int do_mii (cmd_tbl_t * cmdtp, int flag, int argc, char
> *argv[]) int		rcode = 0;
>  	char		*devname;
>
> -#if defined(CONFIG_8xx) || defined(CONFIG_MCF532x)
> +#if defined(CONFIG_8xx) || defined(CONFIG_CF_DOMII)

Please add either a generic define name (not ColdFire specific) or even better 
add declare this mii_init() function as __weak__:

void __mii_init(void)
{
}
int mii_init(void) __attribute__((weak, alias("__mii_init")));

This way we can get rid of these #defines completely.

> 3. Moved-sync-from-m5329evb.c-to-include-asm-m68k-io.patch

Does not apply. I did some cleanup on your original patches, so please rebase 
your work on the u-boot-coldfire custodian repository.

> 4. Added-uart_gpio_conf-for-port-configuration.patch
> 5. Update-timer.patch
> 6. Added-fsl_i2c-header-file.patch
> 7. Added-NAND-Flash-support-and-I2C-support.patch

> diff --git a/board/freescale/m5329evb/m5329evb.c
> b/board/freescale/m5329evb/m5329evb.c index 242eb1a..d23b1c2 100644
> --- a/board/freescale/m5329evb/m5329evb.c
> +++ b/board/freescale/m5329evb/m5329evb.c
> @@ -26,6 +26,7 @@
>
>  #include <config.h>
>  #include <common.h>
> +#include <asm/io.h>
>  #include <asm/immap.h>
>
>  DECLARE_GLOBAL_DATA_PTR;
> @@ -86,3 +87,85 @@ int testdram(void)
>
>  	return (0);
>  }
> +
> +#if (CONFIG_COMMANDS & CFG_CMD_NAND)
> +#include <nand.h>
> +#include <linux/mtd/mtd.h>
> +
> +#define SET_CLE	0x10
> +#define CLR_CLE	~SET_CLE
> +#define SET_ALE	0x08
> +#define CLR_ALE	~SET_ALE
> +
> +static void nand_hwcontrol(struct mtd_info *mtdinfo, int cmd)
> +{

Please move this NAND support into a separate file 
(board/freescale/m5329evb/nand.c).

> 8. Added-GPIO-enabled-for-I2C-signals.patch

As already mentioned above, could you please rebase you patches on the current 
u-boot-coldfire repository? And please address the comments above and 
resubmit. I'll try to merge the patches soon, so that they can be applied to 
mainline before the new merge window closes.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================