[U-Boot-Users] Update for 5329

[Craig Day]

Hi Stefan,

Thanks for the tips (submitting patches). I took a look at the U-Boot 1.2.0
nand_base.c source file and it does have this fix implemented (slightly
different code, but it's updating bufstart like it needs to be), so
apparently someone else has run into the same issue. Are you using 1.2.0 or
1.1.6 (like I am)?

cheers,
Craig

-----Original Message-----
From: Stefan Roese [mailto:sr at denx.de] 
Sent: Wednesday, August 01, 2007 10:23 PM
To: u-boot-users at lists.sourceforge.net
Cc: Craig Day; 'Liew Tsi Chung-r5aahp'; 'Wilson Callan'
Subject: Re: [U-Boot-Users] Update for 5329

Hi Craig,

On Wednesday 01 August 2007, Craig Day wrote:
> I've ported u-boot 1.1.6 over to the LPC3180 (arm926ejs core) and have
> included NAND support.  The nand_write_ecc function in
> drivers/nand/nand_base.c appears to be writing pages correctly, but the
> pointer to the source data in memory for nand_verify_pages does not seem
to
> be updated correctly. Specifically, line 1707 in nand_base.c contains:
> this->data_poi = bufstart; However, the problem is that bufstart is never
> updated, and always points to the beginning of the data source, causing
all
> nand_page_verify calls to compare the newest written pages in NAND flash
to
> the beginning of the data source. After the first block NAND writing fails
> due to nand_verify_pages failing. To fix this I added in:
> bufstart += (1 << this->phys_erase_shift);

Thanks for the detailed explanation. But even better would be to send a
patch 
(best with a signed-off line etc.). A patch sometimes explains a problem 
betten than such an explanation. And if you are correct and it fixes a real 
problem, the patch could be applied directly.

> Have you seen this problem? Or has anyone else run into this problem? Or
is
> there something I'm missing?

We are using the current NAND driver successfully on multiple boards.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================