[U-Boot-Users] [PATCH 2/2] Resend patch to add SBC8641D

[Jon Loeliger]

On Tue, 2007-07-31 at 11:53, Joe Hamman wrote:
> Add support for Wind River's SBC8641D reference board.
> 
> Resend to make MAC addresses private - thanks Ben.
> 
> Signed-off by: Joe Hamman <joe.hamman at embeddedspecialties.com>

Joe,

Can I get you to this patch for me?  I'd like to
see two changes to it, one for TSEC and one for
command line configuration.

> diff -uprN -X dontdiff u-boot/include/configs/sbc8641d.h u-boot-esi/include/configs/sbc8641d.h
> --- u-boot/include/configs/sbc8641d.h	1969-12-31 18:00:00.000000000 -0600
> +++ u-boot-esi/include/configs/sbc8641d.h	2007-07-31 07:15:41.000000000 -0500
> @@ -0,0 +1,597 @@

> +/*
> + * MPC8641HPCN board configuration file

Interesting... :-)


> +/*
> + * Pass open firmware flat tree to kernel
> + */
> +#define CONFIG_OF_FLAT_TREE	1
> +#define CONFIG_OF_BOARD_SETUP	1
> +
> +/* maximum size of the flat tree (8K) */
> +#define OF_FLAT_TREE_MAX_SIZE	8192
> +
> +#define OF_CPU		"PowerPC,8641 at 0"
> +#define OF_SOC		"soc8641 at f8000000"

This needs to be "soc at f8000000" instead.  Ie, drop the part number.
Corresponding changes will be needed in your kernel setup() function
likely too.

> +#define OF_TBCLK	(bd->bi_busfreq / 4)
> +#define OF_STDOUT_PATH	"/soc8641 at f8000000/serial at 4500"

Uh, same stuff here.


> +
> +#if defined(CONFIG_TSEC_ENET)
> +
> +#ifndef CONFIG_NET_MULTI
> +#define CONFIG_NET_MULTI 	1
> +#endif
> +
> +/* #define CONFIG_MII		1 */	/* MII PHY management */
> +
> +#define CONFIG_MPC86XX_TSEC1    1
> +#define CONFIG_MPC86XX_TSEC1_NAME       "eTSEC1"
> +#define CONFIG_MPC86XX_TSEC2    1
> +#define CONFIG_MPC86XX_TSEC2_NAME       "eTSEC2"
> +#define CONFIG_MPC86XX_TSEC3    1
> +#define CONFIG_MPC86XX_TSEC3_NAME       "eTSEC3"
> +#define CONFIG_MPC86XX_TSEC4    1
> +#define CONFIG_MPC86XX_TSEC4_NAME       "eTSEC4"
> +
> +#define TSEC1_PHY_ADDR		0x1F
> +#define TSEC2_PHY_ADDR		0x00
> +#define TSEC3_PHY_ADDR		0x01
> +#define TSEC4_PHY_ADDR		0x02
> +#define TSEC1_PHYIDX		0
> +#define TSEC2_PHYIDX		0
> +#define TSEC3_PHYIDX		0
> +#define TSEC4_PHYIDX		0
> +
> +#define CONFIG_ETHPRIME		"eTSEC1"
> +
> +#endif	/* CONFIG_TSEC_ENET */

So, all of these TSEC parameters have dropped the device
specific part from their names.  Specifically, we need
CONFIG_TSEC1, not CONFIG_MPC86XX_TSEC1 now.


> +
> +#if defined(CONFIG_PCI)
> +  #define  CONFIG_COMMANDS	(CONFIG_CMD_DFL		\
> +				| CFG_CMD_PCI		\
> +				| CFG_CMD_PING		\
> +				| CFG_CMD_I2C)
> +#else
> +  #define  CONFIG_COMMANDS	(CONFIG_CMD_DFL		\
> +				| CFG_CMD_PING		\
> +				| CFG_CMD_I2C)
> +#endif
> +
> +#include <cmd_confdefs.h>

Please recode this with the new Command Line Configuration
style as found in the u-boot-testing tree.

We'll try to get those in for the merge window here.
Having those two re-code efforts in hand will facilitate
that greatly.

Thanks,
jdl