[U-Boot-Users] [PATCH 3/4] microblaze changes

[Wolfgang Denk]

In message <001901c7d792$55a80420$0500a8c0 at monstrone> you wrote:
> Signed-off-by: Michal Simek <monstr at monstr.eu>
> 
> Minor microblaze changes. Change setting for XUPV2P.
> Resolve problem with Barrel shifter
> Repair cmd_mfsl code.

NAK.

> --- a/common/cmd_mfsl.c
> +++ b/common/cmd_mfsl.c
> @@ -357,7 +357,7 @@ int do_rspr (cmd_tbl_t * cmdtp, int flag, int argc, char 
> *argv[])
> 
>   reg = (unsigned int)simple_strtoul (argv[1], NULL, 16);
>   val = (unsigned int)simple_strtoul (argv[2], NULL, 16);
> - if (argc < 1) {
> + if (argc < 2) {
>    printf ("Usage:\n%s\n", cmdtp->usage);
>    return 1;
>   }
...

Please clean up coding style here, too.

...
> --- a/cpu/microblaze/start.S
> +++ b/cpu/microblaze/start.S

... and in all following files as well.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Don't put off for tomorrow what you can  do  today,  because  if  you
enjoy it today you can do it again tomorrow.