[U-Boot-Users] [PATCH 4/4] romfs

[Wolfgang Denk]

In message <001a01c7d792$56644f40$0500a8c0 at monstrone> you wrote:
> 
> --- a/common/cmd_jffs2.c
> +++ b/common/cmd_jffs2.c
> @@ -28,7 +28,7 @@
>   *
>   * This program is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>   * GNU General Public License for more details.

Why exactly did you change this? Please don't.

> +extern int romfs_check (struct part_info *info);
> +extern int romfs_load (char *loadoffset, struct part_info *info, char 
> *filename);

Seems your patch has been  corrupted  by  your  mailer  (line  wrap).
Please fix that.

>  /**
> - * Parses a string into a number.  The number stored at ptr is
> + * Parses a string into a number. The number stored at ptr is
>   * potentially suffixed with K (for kilobytes, or 1024 bytes),
>   * M (for megabytes, or 1048576 bytes), or G (for gigabytes, or
> - * 1073741824).  If the number is suffixed with K, M, or G, then
> + * 1073741824). If the number is suffixed with K, M, or G, then

Please do not implement such "improvements". The  original  code  was
better, so please undo your "optimizations".

> diff --git a/fs/romfs/romfs.c b/fs/romfs/romfs.c

As in all the other the: Coding style.

Please clean up.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There's always been Tower of Babel sort of  bickering  inside  Unix,
but  this  is the most extreme form ever. This means at least several
years of confusion." - Bill Gates, founder and chairman of Microsoft,
about the Open Systems Foundation