[U-Boot-Users] [PATCH 1/2] Updated patch to add SBC8641D

Joe Hamman joe.hamman at embeddedspecialties.com
Mon Aug 6 18:25:53 CEST 2007


Hi Wolfgang,

> -----Original Message-----
> From: wd at denx.de [mailto:wd at denx.de]
> Sent: Monday, August 06, 2007 10:39 AM
> To: joe.hamman at embeddedspecialties.com
> Cc: jdl at freescale.com; u-boot-users at lists.sourceforge.net
> Subject: Re: [U-Boot-Users] [PATCH 1/2] Updated patch to add SBC8641D
> 
> In message <1186410455.22362.7.camel at server> you wrote:
> > Add support for Wind River's SBC8641D reference board.
> >
> > Resend to add fixes per JDL.
> >
> > Signed-off by: Joe Hamman <joe.hamman at embeddedspecialties.com>
> 
> NAK.
> 
> I  reject  this  patch  because  you  are  modifying   global   files
> (config.mk)  without  mentioning  it at all, and in a way that is (1)
> unrelated to your patch and (2) contra-rpoductive  on  most  systems.
> Please don't try again to sneak in code changes this way.

Thanks for catching this.  It was left over from a debugging session and I
never intended it to be submitted.

I'll be more careful in the future.

Regards,
Joe






More information about the U-Boot mailing list