[U-Boot-Users] [ARM] TI DaVinci support, 2nd attempt [1/5]

[Zach Sadecki]

It doesn't appear to be the MUA...  The lines all start with "+" which
indicates to me that diff did that.   The following is a section cut out
of it..  Notice the "#"s in the middle of lines, some lines start with
no #, and each one has a "+" as the first character indicating that diff
created it that way...  Maybe it's a problem with the EOLs?

+# Gary Jennejohn, DENX Software Engineering, <gj at denx.de> # David 
+Mueller, ELSOFT AG, <d.mueller at elsoft.ch> # # (C) Copyright 2003 # 
+Texas Instruments, <www.ti.com> # Swaminathan <swami.iyer at ti.com> # # 
+Davinci EVM board (ARM925EJS) cpu # see http://www.ti.com/ for more 
+information on Texas Instruments # # Davinci EVM has 1 bank of 256 MB 
+DDR RAM # Physical Address:

I understand your dislike for inline patches...  I'd personally prefer
them as attachments, then users can configure their MUAs to display text
attachments inline, but that's not the practice on this list...

Zach


-----Original Message-----
From: ksi at koi8.net [mailto:ksi at koi8.net] 
Sent: Tuesday, August 07, 2007 12:05 PM
To: Zach Sadecki
Cc: U-Boot list
Subject: RE: [U-Boot-Users] [ARM] TI DaVinci support, 2nd attempt [1/5]

On Tue, 7 Aug 2007, Zach Sadecki wrote:

That's exactly the reason why I didn't want to send inline patches.
Every MUA is different and screws up the text in its unique way.

Patch itself is fine and it adds exactly 39 lines.

> I can't get this patch to apply...
>
> Look at the second section (config.mk), it claims to be adding 39 
> lines "@@ -0,0 +1,39 @@", but the section is much shorter than that...

> Also the all the comments seem messed up with the #'s not appearing at

> the start of every line (which is where I suspect the line numbering 
> discrepancy comes from)...
>
> Zach
>
> -----Original Message-----
> From: u-boot-users-bounces at lists.sourceforge.net
> [mailto:u-boot-users-bounces at lists.sourceforge.net] On Behalf Of 
> ksi at koi8.net
> Sent: Monday, August 06, 2007 9:14 PM
> To: U-Boot list
> Subject: [U-Boot-Users] [ARM] TI DaVinci support, 2nd attempt [1/5]
>
> Signed-off-by: Sergey Kubushyn <ksi at koi8.net>
>
> === Cut ===
> diff -purN u-boot.git.orig/board/davinci/dv-evm/board_init.S
> u-boot.git/board/davinci/dv-evm/board_init.S
> --- u-boot.git.orig/board/davinci/dv-evm/board_init.S	1969-12-31
> 16:00:00.000000000 -0800
> +++ u-boot.git/board/davinci/dv-evm/board_init.S	2007-08-06
> 18:06:42.000000000 -0700
> @@ -0,0 +1,29 @@
> +/*
> + * Copyright (C) 2007 Sergey Kubushyn <ksi at koi8.net>
> + *
> + * Board-specific low level initialization code. Called at the very 
> +end
> + * of cpu/arm926ejs/davinci/lowlevel_init.S. Just returns if there is

> +no
> + * initialization required.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <config.h>
> +
> +.globl	dv_board_init
> +dv_board_init:
> +
> +	mov	pc, lr
> diff -purN u-boot.git.orig/board/davinci/dv-evm/config.mk
> u-boot.git/board/davinci/dv-evm/config.mk
> --- u-boot.git.orig/board/davinci/dv-evm/config.mk	1969-12-31
> 16:00:00.000000000 -0800
> +++ u-boot.git/board/davinci/dv-evm/config.mk	2007-08-06
> 18:06:42.000000000 -0700
> @@ -0,0 +1,39 @@
> +#
> +# (C) Copyright 2002
> +# Gary Jennejohn, DENX Software Engineering, <gj at denx.de> # David 
> +Mueller, ELSOFT AG, <d.mueller at elsoft.ch> # # (C) Copyright 2003 # 
> +Texas Instruments, <www.ti.com> # Swaminathan <swami.iyer at ti.com> # #

> +Davinci EVM board (ARM925EJS) cpu # see http://www.ti.com/ for more 
> +information on Texas Instruments # # Davinci EVM has 1 bank of 256 MB

> +DDR RAM # Physical Address:
> +# 8000'0000 to 9000'0000
> +#
> +# Copyright (C) 2007 Sergey Kubushyn <ksi at koi8.net> # # Visioneering 
> +Corp. Sonata board (ARM926EJS) cpu # # Sonata board has 1 bank of 128

> +MB DDR RAM # Physical Address:
> +# 8000'0000 to 8800'0000
> +#
> +# Razorstream, LLC. SCHMOOGIE board (ARM926EJS) cpu # # Schmoogie 
> +board
>
> +has 1 bank of 128 MB DDR RAM # Physical Address:
> +# 8000'0000 to 8800'0000
> +#
> +# Linux-Kernel is expected to be at 8000'8000, entry 8000'8000 # (mem

> +base + reserved) # # we load ourself to 8108 '0000 # #
> +
> +#Provide at least 16MB spacing between us and the Linux Kernel image 
> +TEXT_BASE = 0x81080000
> diff -purN u-boot.git.orig/board/davinci/dv-evm/dv_board.c
> u-boot.git/board/davinci/dv-evm/dv_board.c
> --- u-boot.git.orig/board/davinci/dv-evm/dv_board.c	1969-12-31
> 16:00:00.000000000 -0800
> +++ u-boot.git/board/davinci/dv-evm/dv_board.c	2007-08-06
> 18:06:42.000000000 -0700
> @@ -0,0 +1,211 @@
> +/*
> + * Copyright (C) 2007 Sergey Kubushyn <ksi at koi8.net>
> + *
> + * Parts are shamelessly stolen from various TI sources, original 
> +copyright
> + * follows:
> + * -----------------------------------------------------------------
> + *
> + * Copyright (C) 2004 Texas Instruments.
> + *
> + *
> +---------------------------------------------------------------------
> +--
> +-----
> + * This program is free software; you can redistribute it and/or 
> +modify
> + * it under the terms of the GNU General Public License as published 
> +by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + *  You should have received a copy of the GNU General Public License
> + *  along with this program; if not, write to the Free Software
> + *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> + *
> +---------------------------------------------------------------------