[U-Boot-Users] [PATCH] MPC85xx BA bits not set for 3-bit bank address DIMM

Andy Fleming afleming at gmail.com
Mon Aug 13 21:47:47 CEST 2007


On 7/25/07, Greg Davis <DavisG at embeddedplanet.com> wrote:
> The current implementation does not set the number of bank address bits
> (BA) in the processor. The default assumes 2 logical bank bits. This
> works fine for a DIMM that uses devices with 4 internal banks (SPD
> byte17 = 0x4) but needs to be set appropriately for a DIMM that uses
> devices with 8 internal banks (SPD byte17 = 0x8).
>

This is a small patch, so I'm going to hand apply it.  But for future reference:

1) include your patch as part of your message, not as an attachment.
In rare cases (the patch is quite large), you can attach a gzipped
patch as you did.  But when the patch is 26 lines, just include it.

2) The patch should apply to the top of tree.  This patch modifies
cpu/mpc85xx/spd_sdram.c.orig.  That file doesn't exist in my tree (or
any clean tree).  Try using git.  It will make nice patches with
changelogs and diffstat included.  If you can't use git, you still
need to diff your change in a tree versus a clean tree.  Or at least
make the top of your patch look like this:

--- a/cpu/mpc85xx/spd_sdram.c   2007-07-25 08:42:00.000000000 -0400
+++ b/cpu/mpc85xx/spd_sdram.c   2007-07-25 08:40:10.000000000 -0400

Anyway...applied.




More information about the U-Boot mailing list