[U-Boot-Users] [PATCH] mpc83xx: Split PIB init code from pci.c and add Qoc3 ATM card support

Kim Phillips kim.phillips at freescale.com
Fri Aug 17 02:21:49 CEST 2007


On 16 Aug 2007 13:34:51 +0800
Tony Li <tony.li at freescale.com> wrote:

> The patch splits the PIB init code from pci.c to a single file board/freescale/common/pq-mds-pib.c
> And add Qoc3 ATM card support for MPC8360EMDS and MPC832XEMDS board.
> 
> Signed-off-by: Tony Li <tony.li at freescale.com>
> 

it appears this patch is corrupt:

---
$ ../linux-2.6/scripts/checkpatch.pl --no-tree 53
ERROR: patch seems to be corrupt (line wrapped?)
#109: FILE: board/freescale/common/pq-mds-pib.c:6:
it

ERROR: patch seems to be corrupt (line wrapped?)
#216: FILE: board/freescale/common/pq-mds-pib.h:4:
it

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
---

please resend after turning off line wrapping in your mailer.

> +++ b/include/configs/MPC832XEMDS.h
> @@ -30,6 +30,9 @@
>  #define CONFIG_MPC83XX		1	/* MPC83xx family */
>  #define CONFIG_MPC832X		1	/* MPC832x CPU specific */
>  #define CONFIG_MPC832XEMDS	1	/* MPC832XEMDS board specific */
> +#undef CONFIG_PQ_MDS_PIB /* POWERQUICC MDS Platform IO Board */
> +
> +#undef CONFIG_PQ_MDS_PIB_ATM	/* QOC3 ATM card */

whilst you're at it, please move the blank line above the undef PIB line, to
indicate the h/w relationship.

Thanks,

Kim




More information about the U-Boot mailing list