[U-Boot-Users] [PATCH] PCI_READ_VIA_DWORD_OP: Fix *val uninitialized bug

Wolfgang Denk wd at denx.de
Sat Aug 18 21:39:09 CEST 2007


In message <46C51970.6000207 at necel.com> you wrote:
> From: Shinya Kuribayashi <shinya.kuribayashi at necel.com>
> 
> This patch has been sent on:
> - 6 Jun 2007
> 
> Many users of PCI config read routines tend to ignore the function
> ret value, and are only concerned about the contents of *val. Based
> on this, pci_hose_read_config_{byte,word}_via_dword should initialize
> the *val on dword read error.
> 
> Without this fix, for example, we'll go on scanning bus with vendor or
> header_type uninitialized. This brings many unnecessary config trials.
> 
> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi at necel.com>

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Unix is simple, but it takes a genius to understand the simplicity."
					             - Dennis Ritchie




More information about the U-Boot mailing list