[U-Boot-Users] Some RFCs about U-Boot's the generic FPGA support

[Bruce_Leonard at selinc.com]

Hi Matthias,

I replied to your reply to me before I saw your new post.  Sorry for the 
noise.  See my comments below.

> 
> 1) Make the 'size' parameter obsolete for the 'fpga loadb' command.
> The actual bitstream size is taken from the bitstream.

Agreed, plus you can remove the check against the size parameter passed in 
from the command line that doesn't make any sense.

> 
> 2) Do not bit-swap the bytes in the xilinx bitstream. When using the
> slave serial code the bits may not be swapped. I can imagine that this 
> swapping requirement comes from a special board layout. So is should
> be done in board specific code. When removing the swapping code, we
> can get rid of the complete malloc/free stuff in fpga_loadbitstream().

I would make this optional/configurable as I mentioned in my last post. 
Doing the bit swapping makes sense for a little endian processor but 
doesn't make sense for the big endian machines like the PPC.

> 
> 4) Make post() and pre() callback optional in relocation. So do
> not relocate NULL-pointers. This has been discussed a short time ago
> on the list.

Agreed

> 
> 6) Add some more devices.
> 

More devices are always good.  That way folks in the future have a 
starting place.

> 
> BTW: Are there any boards that use the FPGA stuff and that are not 
> made public ?:-)
>

Our board is totally custom and will never be used by anyone but us, but 
as Wolfgang pointed out that's not the lists problem that's our problem. 
Folks using u-boot need to be aware that things change and they need to be 
careful when doing pulls from the repository.
 
> Matthias
> 
> diff --git a/common/cmd_fpga.c b/common/cmd_fpga.c
> index 3444091..2e1cf26 100644

I haven't gone through your diffs yet, I wanted to get comments back to 
you early.  I'll look them over today and give any feedback if I need to 
later.

Thanks for your work on this.  It saves me from the embarrassment of 
having to submit patches for the first time ;).  Not looking forward to 
that beating!

Bruce