[U-Boot-Users] [PATCH] RFC: generic property fixup mechanism for LIBFDT

[Kim Phillips]

On Wed, 22 Aug 2007 09:18:20 -0400
Jerry Van Baren <gerald.vanbaren at smiths-aerospace.com> wrote:

> IMO your proposal is not acceptable.  Follow Grant's advice and the 
> current cpu/mpc83xx/cpu.c methodology.

?  Bartlomiej's first patch followed the 83xx 'methodology', which Grant
commented on, which is what Bartlomiej tried to fix here.  Maybe I
missed something, but anyway, now that the window has closed, we can
arrange to fix libfdt support for all powerpc boards for the next
release.

What about having a list of functions to call?  It could be called
something like fdt_update_sequence, and be similar in implementation to
lib_ppc/board.c's init_sequence.  It could also reside in lib_ppc,
esp. since, e.g. all powerpc's have a timebase, and to help naturally
enforce a certain level of consistency among powerpc board code.  The
updater/fixup/"setter" functions would only need be passed the pointer
to the base of the blob to update.

The update functions need to be rewritten to be independent of the
OF_CPU, OF_SOC, OF_QE, OF_STDOUT_PATH defines.  Those should all be
removed (OF_TBCLK might be a bit harder to get rid of though --
implement TBCLK_DIVISOR instead?).  btw, Linux is changing the name of
the soc node from, e.g. "soc8360", to simply "soc", and u-boot needs to
handle transitions like these better.  Instead of adding support for
both name types, the update functions can handle these situations by
using some of the higher level functions available in libfdt, such as
fdt_find_node_by_type or even fdt_find_compatible_node.

Kim