[U-Boot-Users] [PATCH 1/2][MIPS] Update asm string header

[Shinya Kuribayashi]

Wolfgang Denk wrote:
> In message <46D295EF.3030003 at necel.com> you wrote:
>> [MIPS] Update asm string header
>>
>> From: Shinya Kuribayashi <shinya.kuribayashi at necel.com>
>>
>> This includes several bugfixes and cleanups in the latest upstream:
> ...
>> diff --git a/include/asm-mips/string.h b/include/asm-mips/string.h
>> index 463a111..4739c18 100644
>> --- a/include/asm-mips/string.h
>> +++ b/include/asm-mips/string.h
>> @@ -1,18 +1,26 @@
> ...
>> +/*
>> + * Most of the inline functions are rather naive implementations so I just
>> + * didn't bother updating them for 64-bit ...
>>   */
>> -#ifndef __ASM_MIPS_STRING_H
>> -#define __ASM_MIPS_STRING_H
>> +#if 1 /* #ifdef CONFIG_32BIT */
> 
> Please remove this (and the corresponding #endif).

I just wanted to indicate that this funcs is valid for 32-bit mode.
But, I agree that it's not a proper workaround.

> Ummm... does this work on 64 bit MIPS systems, too?

No it doesn't, according to the upstream's decision.

Unfortunately, AFAIK, current MIPS port doesn't have general configs
for 32/64-bit mode. It might be better to use lib_generic/string.c for
both CPU mode in this situation.

Thanks,

    Shinya Kuribayashi