[U-Boot-Users] AT91SAM9260-EK: Trying to load U-Boot env from NAND

[Wolfgang Denk]

In message <14124814.post at talk.nabble.com> you wrote:
> 
> Yes! I get it work, the problem was, that it had a problem to accept the
> crc32-Checksum. So I just erased the sequence where this happens. Here the
> patchfile:
> 
> --- env_nand.c	2007-11-30 14:15:03.000000000 +0100
> +++ env_nand.c	2007-11-30 14:16:17.000000000 +0100
> @@ -247,13 +247,7 @@ void env_relocate_spec (void)
>  		crc2_ok = (crc32(0, tmp_env2->data, ENV_SIZE) == tmp_env2->crc);
>  	}
>  
> -	if(!crc1_ok && !crc2_ok)
> -		return use_default();
> -	else if(crc1_ok && !crc2_ok)
> -		gd->env_valid = 1;
> -	else if(!crc1_ok && crc2_ok)
> -		gd->env_valid = 2;
> -	else {
> +	
>  		/* both ok - check serial */

You mean you completely castrated all logic that would verify if the
environment is OK? Arrggghhhh...

> Maybe it isn't the best solution but it works ;)

You THINK it works, but actually it's completely broken.

Don't do that!!!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"UNIX was not designed to stop you from doing stupid things,  because
that would also stop you from doing clever things."       - Doug Gwyn