[U-Boot-Users] Can U-boot Autodetect arch/ppcversusarch/powerpc from info in the uImage?

Wolfgang Denk wd at denx.de
Sun Dec 9 16:00:38 CET 2007

In message <1197205927.937.51.camel at gentoo-jocke.transmode.se> you wrote:
> Made a new patch with Jerrys comments addressed. Also renamed

I still object against this modification.

> +#ifdef CFG_OF_TREE
> +	char	*of_flat_tree = CFG_OF_TREE;
> +#else
>  	char	*of_flat_tree = NULL;
> +#endif
>  	ulong	of_data = 0;
>  #endif

I hereby NAK this patch for 3 reasons:

1) The patch does not solve a problem. Instead of harwiring the
   address, you can just pass it as argument to the bootm command
   which seems more straightforward to me

2) The patch causes confusion. Documented behaviour is that "bootm"
   with one or two arguments (kernel address, or kernel plus ramdisk
   addresses) will boot a non-OF enabled kernel. With this patch,
   "bootm" will behave different on systems where the CFG_OF_TREE has
   been silected - which is usually not known to and cannot be
   checked by the end user, thus causing confusion.

3) With the patch applied and CFG_OF_TREE defined, there is no way to
   boot a non-OF kernel, thus breaking backward compatibility.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you're not part of the solution, you're part of the problem.

More information about the U-Boot mailing list