[U-Boot-Users] [PATCH 0/6] cfi_flash cleanups

Haavard Skinnemoen hskinnemoen at atmel.com
Tue Dec 11 16:28:14 CET 2007

This is a series of cleanups to the CFI driver I did while debugging
why it refused to work on my AVR32 boards, rebased on top of the
latest CFI custodian tree with "[PATCH] CFI: synchronize command
offsets with Linux CFI driver" applied as well.

I'm not completely done yet, as I need more fixes to make the CFI
driver work on boards like the ATNGW100. But these initial patches are
seriously painful to rebase (especially #3 in this series,) so I'd
like some feedback from others if I'm moving in an acceptable
direction with this.

I've compile-tested the whole thing using MAKEALL on ppc (no point in
testing on avr32 since no boards use this driver yet.) mcc200 failed,
but it complains about lots of undefined symbols that has nothing to
do with the CFI driver, so I'm pretty sure it isn't my fault.

Please let me know which parts of this are acceptable, and if there's
something that can be done in a better way. And if you merge parts
1-3 (or even more of them), I'd be _very_ happy :-)

There are a couple of remaining cleanups I'd like to make that go on
top of this stuff, mostly related to refactoring the command set
handling and adding manufacturer-specific fixups.

Haavard Skinnemoen (6):
      cfi_flash: Break long lines
      cfi_flash: Make some needlessly global functions static
      cfi_flash: Reorder functions and eliminate extra prototypes
      cfi_flash: Introduce read and write accessors
      Introduce map_physmem() and unmap_physmem()
      cfi_flash: Use map_physmem() and unmap_physmem()

 drivers/mtd/cfi_flash.c     | 1677 +++++++++++++++++++++++--------------------
 include/asm-arm/io.h        |   17 +
 include/asm-avr32/io.h      |   20 +
 include/asm-blackfin/io.h   |   17 +
 include/asm-i386/io.h       |   17 +
 include/asm-m68k/io.h       |   18 +
 include/asm-microblaze/io.h |   17 +
 include/asm-mips/io.h       |   17 +
 include/asm-nios/io.h       |   17 +
 include/asm-nios2/io.h      |   17 +
 include/asm-ppc/io.h        |   17 +
 11 files changed, 1077 insertions(+), 774 deletions(-)

More information about the U-Boot mailing list