[U-Boot-Users] [PATCH 4/6] cfi_flash: Introduce read and write accessors
Haavard Skinnemoen
hskinnemoen at atmel.com
Wed Dec 12 10:31:10 CET 2007
On Tue, 11 Dec 2007 23:05:37 +0100
Wolfgang Denk <wd at denx.de> wrote:
> In message <20071211181317.7a9abc4e at dhcp-252-066.norway.atmel.com> you wrote:
> >
> > > Kumar is right. We definitely must use the "real" accessor functions.
> >
> > Yeah, I agree too.
> >
> > From a quick glance, m68k, powerpc, nios and nios2 lack these
> > functions. Anything special I need to know about those architectures,
> > or should I just grab them from Linux or use volatile?
>
> Grabbing the code from Linux is fine with me; we must test this
> extensively in any case. But I would not reject the patch if you made
> life easy for you and just used volatile for these archs.
powerpc and m68k seem to use volatile in Linux too, so those are easy.
There's no nios/nios2 support in Linux, so I think I'll just go with
volatile for those as well. It should at least not break the CFI driver
since it uses volatile already.
Haavard
More information about the U-Boot
mailing list