[U-Boot-Users] [PATCH 1/2] mpc85xx: Add support for SBC8548
Joe Hamman
joe.hamman at embeddedspecialties.com
Thu Dec 13 13:39:06 CET 2007
> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org]
> Sent: Wednesday, December 12, 2007 10:20 PM
> To: joe.hamman at embeddedspecialties.com
> Cc: afleming at gmail.com; u-boot-users at lists.sourceforge.net
> Subject: Re: [U-Boot-Users] [PATCH 1/2] mpc85xx: Add support for SBC8548
>
>
> Missing updates to MAKEALL
>
Thanks for the catch!
> [snip]
>
> > +
> > +typedef struct epld_reg {
> > + u_char bd_rev; /* Board revision */
> > +} epld_reg_t;
>
> seems over kill for the one usage below.
>
> >
> > +
> > +unsigned int get_board_rev(void)
> > +{
> > + volatile epld_reg_t *epld = (epld_reg_t *)CFG_BD_REV;
> > +
> > + return ((epld->bd_rev) >> 4);
> > +}
> > +
> > +#if defined(CONFIG_OF_BOARD_SETUP)
> > +void
> > +ft_board_setup(void *blob, bd_t *bd)
> > +{
> > + ft_cpu_setup(blob, bd);
I agree. Originally I thought there would be more in the structure.
>
> PCI of setup code?
>
> >
> > +}
> > +#endif
> > +
Added.
Updated patch coming...
Joe
More information about the U-Boot
mailing list