[U-Boot-Users] [PATCH] TFTP: add host ip addr support
Jerry Van Baren
gerald.vanbaren at ge.com
Mon Dec 24 17:40:26 CET 2007
Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
>
> diff --git a/common/cmd_net.c b/common/cmd_net.c
> index 21682c0..2fb0e7c 100644
> --- a/common/cmd_net.c
> +++ b/common/cmd_net.c
> @@ -51,7 +51,7 @@ int do_tftpb (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> U_BOOT_CMD(
> tftpboot, 3, 1, do_tftpb,
> "tftpboot- boot image via network using TFTP protocol\n",
> - "[loadAddress] [bootfilename]\n"
> + "[loadAddress] [host ip addr:bootfilename]\n"
Hi Jean-Christophe,
Interesting. I can see how that would be useful rather than having to
modify the dhcp server configuration when you want to use an alternate
server.
Critique: the help is misleading: "host ip addr:" is optional so it
needs another set of [] around it. Having spaces in "host ip addr" is
more readable, but makes it look like it is three things or perhaps a
keyword.
I would suggest the following, but there may be a better way...
"[loadAddress] [[hostIPaddr:]bootfilename]\n"
Best regards,
gvb
More information about the U-Boot
mailing list