[U-Boot-Users] [PATCH] common/cmd_mii.c: Add sanity argc check
Shinya Kuribayashi
shinya.kuribayashi at necel.com
Thu Dec 27 07:56:35 CET 2007
Shinya Kuribayashi wrote:
> If type mii command without arguments, we suffer from uninitialized argv[]
> entries; for example we MIPS get stuck by TLB error.
>
> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi at necel.com>
> ---
>
> common/cmd_mii.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/common/cmd_mii.c b/common/cmd_mii.c
> index b771322..b99bd06 100644
> --- a/common/cmd_mii.c
> +++ b/common/cmd_mii.c
> @@ -438,6 +438,11 @@ int do_mii (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
> int rcode = 0;
> char *devname;
>
> + if (argc < 2) {
> + printf("Usage:\n%s\n", cmdtp->usage);
> + return 1;
> + }
> +
> #if defined(CONFIG_8xx) || defined(CONFIG_MCF532x)
> mii_init ();
> #endif
By the way, cmd_mii.c has _another_ do_mii() which is enabled for
CONFIG_TERSE_MII user. But it seems there is no CONFIG_TERSE_MII user.
I just wonder that do_mii() is in the transition to the newer version.
thanks,
Shinya
More information about the U-Boot
mailing list