[U-Boot-Users] CFG_EEPROM_PAGE_WRITE_ENABLE [Was: Re: [PATCH 2/9] Add driver for National Semiconductor LM73 temperature sensor]

Larry Johnson lrj at arlinx.com
Thu Dec 27 18:16:42 CET 2007


Stefan Roese wrote:
> Hi Larry,
> 
> On Saturday 22 December 2007, Larry Johnson wrote:
>> This driver is based on the driver for the LM75.
> 
> Patch seems to be line wrapped. Please fix and resubmit.
> Thanks.
> 
> Best regards,
> Stefan
> 
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================

I noticed that the offending line was part of a check to ensure that the
symbol "CFG_EEPROM_PAGE_WRITE_ENABLE" is defined.  However, I don't see
this switch being used anywhere in the code, although several other HWMON
drivers also check that it is defined.  Does anyone know of a reason to
keep defining it?

Best regards,
Larry






More information about the U-Boot mailing list