[U-Boot-Users] [patch] do not use linux/string.h in sha1.c on hosts

Josh Boyer jwboyer at gmail.com
Fri Dec 28 02:51:38 CET 2007


On Thu, 27 Dec 2007 21:15:16 +0100
Wolfgang Denk <wd at denx.de> wrote:

> In message <4773FCEF.2040507 at semihalf.com> you wrote:
> >
> > >> But IIRC mkimage does not use any sha1 code ...
> > > 
> > > the Makefile claims otherwise ... patch attached to remove sha1.o from mkimage
> > > linking since it isnt actually used.
> 
> Indeed the Makefile contained a not needed reference.
> 
> > It is likely we'll need sha1 support in mkimage for the new uImage
> > format. Let's wait with this patch until mkimage extension to the new
> > uImage format is settled down.
> 
> I'm not so sure. Maybe it's better to clean up now, and deal with the
> new image format requirements when we're at it. Please note that  the
> mkimage  code  has  recenty  been added to the Linux kernel tree, and
> there the sha1 reference was also removed. I think it makes sense  to
> keep both in sync...

Actually, it hasn't been added yet.  I've only sent out one round of
patches so far.  And those included the sha1.c code because of the
exact same reason.  I wanted to keep them in sync :)

josh




More information about the U-Boot mailing list