[U-Boot-Users] [PATCH 2/9] Add driver for National Semiconductor LM73 temperature sensor
Larry Johnson
lrj at arlinx.com
Fri Dec 28 14:43:41 CET 2007
Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 13:18 Thu 27 Dec , Stefan Roese wrote:
>> On Sunday 23 December 2007, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>>> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
>>>> index cebb2ba..32e3f44 100644
>>>> --- a/drivers/hwmon/Makefile
>>>> +++ b/drivers/hwmon/Makefile
>>>> @@ -34,6 +34,7 @@ COBJS-y += adm1021.o
>>>> COBJS-y += ds1621.o
>>>> COBJS-y += ds1722.o
>>>> COBJS-y += ds1775.o
>>>> +COBJS-y += lm73.o
>>>> COBJS-y += lm75.o
>>>> COBJS-y += lm81.o
>>> I will send soon (today or tomorow) the Makefile with conditional
>>> compilation please rebase your patch about drivers on it.
>> I would like to get those patches accepted and merged in this merge window. We
>> should not delay this by waiting on your conditional compilation rework
>> (which is good of course). So I suggest to get such patches merged right now
>> and fix possible problems with future additions later.
>
> I understand you view but il will great if the new driver could be use
> conditional Makefile.o
>
> Could you do this modification pls
>
> COBJS-$(CONFIG_DTT_LM73) += lm73.o
>
> instead of
>> +COBJS-y += lm73.o
>
> and remove if ifdef CONFIG_DTT_LM73 from the lm73.c
>
> Thanks by advance,
> J.
I have tested a patch to make this change and to remove the references
to "CFG_EEPROM_PAGE_WRITE_ENABLE". If there is no objection, I would
prefer to submit this patch after Stefan finishes adding the original
patch, rather than amend the original patch.
Best regards,
Larry
More information about the U-Boot
mailing list