[U-Boot-Users] [PATCH 2/9] Add driver for National Semiconductor LM73 temperature sensor
Larry Johnson
lrj at arlinx.com
Fri Dec 28 17:23:44 CET 2007
Stefan Roese wrote:
> On Friday 28 December 2007, Larry Johnson wrote:
>>> I understand you view but il will great if the new driver could be use
>>> conditional Makefile.o
>>>
>>> Could you do this modification pls
>>>
>>> COBJS-$(CONFIG_DTT_LM73) += lm73.o
>>>
>>> instead of
>>>
>>>> +COBJS-y += lm73.o
>>> and remove if ifdef CONFIG_DTT_LM73 from the lm73.c
>>>
>>> Thanks by advance,
>>> J.
>> I have tested a patch to make this change and to remove the references
>> to "CFG_EEPROM_PAGE_WRITE_ENABLE". If there is no objection, I would
>> prefer to submit this patch after Stefan finishes adding the original
>> patch, rather than amend the original patch.
>
> Yes, I would like to do it this way too.
>
> I'm waiting for some final patches from Matthias and will send the pull
> request to Wolfgang after those are merged today or latest tomorrow.
>
> Best regards,
> Stefan
>
> =====================================================================
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
> =====================================================================
BTW, my patches will have some interaction with what Matthias is doing. In
particular, the addition and correction of Denali SDRAM definitions to
"ppc440.h" causes the compiler to warn of some preprocessor redefinitions
in "sequoia/sdram.h". To avoid this, he could use the new version of this
file that my patches create, or (even better IMO), just drop file "sdram.h"
completely, as everything he needs should be in "ppc440.h".
I should have a patch soon that makes this and other changes to
"sequoia/sdram.c" to take advantage of the new code I've submitted. I
will post it when it is ready.
Best regards,
Larry
More information about the U-Boot
mailing list