[U-Boot-Users] [PATCH] Add sync at the end of flash_write_cmd for MPC86xx

Andrew Dyer amdyer at gmail.com
Mon Feb 5 22:01:10 CET 2007


On 2/5/07, Haiying Wang <r54964 at freescale.com> wrote:
> Add sync at the end of flash_write_cmd for MPC86xx
> to ensure write command are really finished before reading data
>
> Signed-off-by: Haiying Wang <haiying.wang at freescale.com>
> ---
> According to Tolunay's first suggestion, this patch for cfi_flash
> driver fixed the flash operation error on MPC8641HPCN board. Since there
> is not such flash error reported on 85xx, 83xx platform and as Tolunay
> said, there is not a PowerPC macro to define, I just use CONFIG_MPC86xx
> for now. I also tested his second suggestion(adding udelay directly
> after reset command), but flash still failed to work.

Given that this is already looks to have been an issue on blackfin and
now PPC (and probably some MIPS also), I would suggest it's better to
define a macro in the CPU definition for your arch and blackfin and do
a generic test like so:

#ifdef SYNC
    SYNC;
#endif

Maybe you can come up with a more descriptive name than SYNC :-)

I had e-mailed Tolunay about this and he concurred.

-- 
Hardware, n.:
        The parts of a computer system that can be kicked.




More information about the U-Boot mailing list