[U-Boot-Users] [PATCH] Add sync at the end of flash_write_cmd for MPC86xx
Tolunay Orkun
listmember at orkun.us
Tue Feb 6 09:50:08 CET 2007
Stefan Roese wrote:
> On Monday 05 February 2007 22:11, Haavard Skinnemoen wrote:
>>> #ifdef SYNC
>>> SYNC;
>>> #endif
>> Better to drop the #ifdef and just add empty stubs for the arches that
>> don't need it.
>
> Yes, please do it this way.
I think defining the SYNC macro in architecture files is probably better
but #ifdef wrapper would avoid touching architectures that does not have
SYNC concept.
I guess at this moment we need a real (not a stub) SYNC for all PowerPC
variants and Blackfin. I do not know if other architectures supported by
U-Boot have such instructions in instruction set. So, it is probably the
best time for those architecture people to speak up.
I think this patch should be independent than the cfi_flash.c patch.
cfi_flash.c patch will depend on this patch applied first.
Best regards,
Tolunay
More information about the U-Boot
mailing list