[U-Boot-Users] AT91 NAND om AT91SAM9260EK

[Wolfgang Denk]

In message <010801c74c98$716c2040$01c4af0a at Glamdring> you wrote:
>
> > The only thimg I'm not really happy with (whithout having any  better
> > suggestion)  is  to  move this into drivers - drivers is intended for
> > general, CPU and board independent  code,  where  this  is  obviously
> > specific to a certain class of processors.
...
> I think at45.c is CPU independent, but spi.c is closely tied to Atmel 
...
> at45.c contains commands which are specific to the at45 series of dataflash.

Sounds contradictory ;-)

But I agree with the latter statement: at45.c is specific to the at45
series of dataflash, which in turn is specific to a certain class  of
processors. You probably cannot find this on PowerPC, MIPS, NIOS, ...
systems.

That's why I wonder if this should not be located somewhere under
cpu/...

> While the functions in at45.c are called AT91xxx they really do not

Then that naming should be fixed...

> depend on any specific SPI H/W and it can thus be used
> with any chip which implements the SPI API defined
> by cpu/arm920t/at91rm9200/spi.c

But we agree that this *is* specific to a certain class of processors
of the ARM family, right?

> If you let it remain in the board directories as is, then
> you duplicate this for each board.

This is not what I want, nor what I suggested.

> I think a good place for any driver stuff which is useable
> both by at91 and ap7xxx chips could be an
> board/atmel/drivers directory.

No. Not board/... if you are talking about chip specific features.

> An alternative would be a cpu/atmel/drivers directory.

or cpu/atmel/ (without the /drivers  part),  like  we  do  for  other
processors.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The perversity of nature is nowhere better demonstrated by  the  fact
that,  when  exposed to the same atmosphere, bread becomes hard while
crackers become soft.