[U-Boot-Users] [PATCH] Add first Netstal board HCU4

[Niklaus Giger]

Am Samstag, 10. Februar 2007 08:59 schrieb Stefan Roese:
> Hi Niklaus,
>
> On Friday 09 February 2007 21:37, Niklaus Giger wrote:
> > h) ./MAKEALL
> > Most target run okay, but I have errors like
> > Configuring for p3mx board...
> > p3mx.c:48:18: error: p3mx.h: No such file or directory
> > p3mx.c:48:18: error: p3mx.h: No such file or directory
> > which I believe are unrelated to my changes.
>
> That's my fault. Fixed soon.
>
> > I am unsatisfied that I had to add a flash.c to my board, but I have at
> > the moment no idea how a clean solution should look like. But I think in
> > the various flash.c there is a lot of duplicated code around.
>
> Yes, that has mostly historic reasons. So why do you have to use a board
> specific flash driver and not the common cfi driver?
Because I started with a board that had a board specific flash.c, which 
worked. And a first attempt to use the common CFI failed, as I mixed too many 
changes. But I will try next week to follow you suggestion.
>
> > As our board has ECC memory, I would like to submit in a second step a
> > patch to get ECC working on  PPC405.
>
> So the current patch doesn't include this ECC support? Do you use the 4xx
> SPD driver (cpu/ppc/spd_sdram.c) or the no SPD driver (cpu/ppc/sdram.c)? Or
> even a board specif one?
Yes it does not. 

I did not want to mix in a single patch a new board and a new feature. And as 
it is the first time I work with git I not know how to easily work on two 
different patches at the same time. But I will try next week to come up with a 
patch for ECC.

I think I use cpu/ppc/spd_sdram.c as I call in my init_dram procedure  
   dram_size = spd_sdram(0);
Alternatively I first brought up my board using the known good values for the 
sdram registers in my procedure fixed_hcu4_sdram, which I left for debugging 
purposes #if !defined(CONFIG_SPD_EEPROM).

> Best regards,
> Stefan

Thanks for your tips.

Best regards

-- 
Niklaus Giger