[U-Boot-Users] [PATCH0/2] Re-do the patch for adding DO_SYNC in flash_write_cmd

Wolfgang Denk wd at denx.de
Sat Feb 10 22:54:17 CET 2007


In message <200702100840.46587.sr at denx.de> you wrote:
>
> > > Or, to be sure, ""sync;isync"
> 
> I would not do this. Please let a "sync" instruction _not_ do a "isync" too. 
> There will be times when you explicitly _don't_ what this.

Note that the current assember #define SYNC does exactly what I quoted
above...

> Why not use
> 
> #define sync()  __asm__ __volatile__ ("sync" : : : "memory");
> 
> from include/asm-ppc/io.h? This seems to be exactly what we need.

Indeed. Let's use that!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
One difference between a man and a machine is that a machine is quiet
when well oiled.




More information about the U-Boot mailing list