[U-Boot-Users] [PATCH] Add S3C2410 MMC/SD support

[Harald Welte]

On Sat, Feb 17, 2007 at 12:48:31AM +0100, Haavard Skinnemoen wrote:
> On 2/17/07, Harald Welte <laforge at openmoko.org> wrote:
> >This patch adds MMC/SD support to the S3C2410 SoC code in u-boot
> 
> >+               /* FIXME fill in the correct size (is set to 32MByte) */
> >+               mmc_dev.blksz = 512;
> >+               mmc_dev.lba = 0x10000;
> 
> So...what happens if the card really isn't exactly 32 MB?

nothing really.  I've used up to 1GB cards so far.  Just the size
indication printed is wrong.  Yes, this is ugly.  I should either remove
printing the size, or implement it correctly.

> This looks like it's been copied from pxa with few modifications ;)

indeed.

> I wonder if we could perhaps create a common header file for the mmc
> protocol definitions instead of duplicating them all over the place?
> This file consists entirely of constants and data structures from the
> MMC spec, and isn't really arch-specific at all.
> 
> I have a patch that adds support for the mmc controller on the
> AT32AP7000 chip, and which adds the exact same definitions all over
> again to the AVR32 include directory. The same driver should work on
> several AT91 chips, which means that we need to add them to the
> at91rm9200 and at91sam926x directories too.
> 
> Or we could just move everything to a common file and be done with it...

will do so in the next version of the patch.

-- 
- Harald Welte <laforge at openmoko.org>          	        http://openmoko.org/
============================================================================
Software for the world's first truly open Free Software mobile phone