[U-Boot-Users] [PATCH] Update SystemACE driver for 16bit access

Stefan Roese sr at denx.de
Wed Feb 21 20:58:21 CET 2007


On Wednesday 21 February 2007 17:25, Grant Likely wrote:
> > @@ -119,6 +119,14 @@ block_dev_desc_t *systemace_get_dev(int dev)
> >                 systemace_dev.removable = 1;
> >                 systemace_dev.block_read = systemace_read;
> >
> > +#if (CFG_SYSTEMACE_WIDTH == 16)
> > +               /*
> > +                * By default the SystemACE comes up in 8-bit mode.
> > +                * Ensure that 16-bit mode gets enabled.
> > +                */
> > +               ace_writew(0x0001, 0);
> > +#endif
> > +
>
> I've got a similar patch in my tree;  How about something like this
> instead:
>
> ace_writew(CFG_SYSTEMACE_WIDTH == 8 ? 0 : 0x0001, 0);
>
> That way it handles both conditions; 8 when it should be 16, and 16
> when it should be 8

Even better. Will update my version.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
=====================================================================




More information about the U-Boot mailing list