[U-Boot-Users] Submitting patches

[Grant Likely]

On 2/26/07, Timur Tabi <timur at freescale.com> wrote:
> Grant Likely wrote:
>
> > hehehe, that's a lot of work for a simple thing.  Drop the git-commit
> > -m flag and use -F instead to add the commit log from a file (or use
> > neither and git-commit will bring up an editor).
>
> I haven't tried it, but according to the online help, -F sets the commit
> *message*, which is the one-line text that becomes the subject line.
> git-commit.txt contains the block of text that appears above the "diff" line.

Actually only the first line of the commit message becomes the subject
line.  Subsequent lines are the detail.

Typical convention for the commit message seems to be: 1 line summary;
1 blank line; detailed description; signed-off-by lines.  In fact,
when using the -m flag, you can add a detailed description too by
inserting carriage returns within the quotes.

For example:
$ git commit -m "This is the subject line
>
> This is detail line 1
> This is detail line 2
> This is detail line 3" -s
$

which gives:
$ git log HEAD~1..HEAD
commit 122b83871419754ee24e3d28a72a302958b7c3fa
Author: Grant Likely <grant.likely at secretlab.ca>
Date:   Mon Feb 26 15:53:35 2007 -0700

    This is the subject line

    This is detail line 1
    This is detail line 2
    This is detail line 3

    Signed-off-by: Grant Likely <grant.likely at secretlab.ca>
$

>
>  > You can also use -s
> > to add your signoff line too.
>
> I do use -s:
>
> PATCHFILE=`git-format-patch -s $IGNOREEOL HEAD^ `

That works too.  :-)

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195