[U-Boot-Users] [PATCH] Support for csb535fs / i.MX21 LiteKit.

[Grant Likely]

On 2/27/07, Txema Lopez <tlopez at aotek.es> wrote:
> Hi all,
> This patch, for the 1.2.0 version, adds support for the csb535fs board
> embedded in a csb935fs breakout board. The set is known as i.MX21 Litekit.

With a quick perusal, the patch looks mostly okay.  Unfortunately,
it's inconvenient to review because it was sent as a gzipped
attachment instead of inline (I can't just hit 'reply' and start
typing comments).

Here are some general comments:
- You should add your copyright to all new files that you've added.
At the moment, your copyright only appears on a few of the new files.
- Where did include/asm-arm/arch-imx21/imx21-regs.h come from?  There
is no copyright notice on it at all.
- There's a fair bit of inconsistent whitespace (intermixed space and
tab characters).
- I do wonder at the amount of boilerplate required for each new board
port (but that's a longer ranged questions directed at the whole of
u-boot).

Cheers,
g.


-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195