[U-Boot-Users] [PATCH 1/2] Add support for 802.3ae to MII-PHY code

Haavard Skinnemoen hskinnemoen at gmail.com
Thu Jan 25 19:14:02 CET 2007

On 1/23/07, Ben Warren <bwarren at qstreams.com> wrote:

> +int miiphy_set_attribute(char *devname, enum miiphy_attr attr, void *value)

Maybe it's just me, but the need for a function like this just screams
"give ownership of struct mii_dev back to the driver". And it's not
really about "attributes" at all -- it's about callbacks, so I think
the function is misnamed.

Why not simply let the driver allocate its own struct mii_dev and
initialize it as it sees fit? It would simplify the interface a lot.


More information about the U-Boot mailing list