[U-Boot-Users] [PATCH] mpc85xx: protect memcpy to bad address if a mac-address is missing from dt

Dan Malek dan at embeddedalley.com
Wed Jan 31 02:56:20 CET 2007

On Jan 30, 2007, at 4:08 PM, Kim Phillips wrote:

>  #if defined(CONFIG_MPC85XX_TSEC1)

This is silly.  A TSEC is a TSEC regardless of the core.
We need to stop this hackery and put a few seconds
of thought into this rather than just replicating code
where the differences are a couple of minor
search/replace edit operations.  The whole of the
Freescale processor area has recently been just
a bunch of copy, copy, copy with little change to
justify all of these replicated files.  The SOCs are
collections of functional blocks just arranged in
different ways.  The software should reflect that.


	-- Dan

More information about the U-Boot mailing list