[U-Boot-Users] U-boot ColdFire development

[Liew Tsi Chung-r5aahp]

Stefan and Wolfgang,

	Sorry about previous statement. I meant is exclude it from built but still able to build it if it is not CF.

...
#ifndef __M68K__
   sync();
#endif   
...

	Anyway, the inline in io.h works too! :)

Regards,
TsiChung


-----Original Message-----
From: Stefan Roese [mailto:sr at denx.de] 
Sent: Thursday, July 26, 2007 11:51 PM
To: u-boot-users at lists.sourceforge.net
Cc: Liew Tsi Chung-r5aahp; w.wegner at astro-kom.de
Subject: Re: [U-Boot-Users] U-boot ColdFire development

TsiChung,

On Friday 27 July 2007, Liew Tsi Chung-r5aahp wrote:
> > For the sync() function (needed for CFI):
> > is it useful to have it for each board, or shouldn´t this be handled 
> > somewhere in lib_m68k?
>
> Have not looked deep into the CFI driver code to see there is a need 
> for it. If there is no need for it, it will be removed.

The sync() in the CFI driver *is* needed. At least on some architectures. 
Please move the definition of sync() from the board specific file to the common header include/asm-m68k/io.h to something like this:

static inline void sync(void)
{
	/*
	 * Not needed on ColdFire architecture
	 * Added for compatibility reasons (CFI driver...)
	 */
}

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de =====================================================================